Skip to content

8379967: (process) Improve ProcessBuilder error reporting#115

Closed
tstuefe wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-tstuefe-2240ff41-master
Closed

8379967: (process) Improve ProcessBuilder error reporting#115
tstuefe wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-tstuefe-2240ff41-master

Conversation

@tstuefe
Copy link
Copy Markdown
Member

@tstuefe tstuefe commented Mar 18, 2026

Backport to JDK26u:

This one is a prerequisite of the upcoming fix for https://bugs.openjdk.org/browse/JDK-8377907 "(process) Race in ProcessBuilder can cause JVM hangs".

Risk: Pretty low.

Tested:

  • Ran manual tests (java/lang/ProcessBuilder) on linux x64 and linux x64 alpine
  • GHAs

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8379967 needs maintainer approval

Issue

  • JDK-8379967: (process) Improve ProcessBuilder error reporting (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk26u.git pull/115/head:pull/115
$ git checkout pull/115

Update a local copy of the PR:
$ git checkout pull/115
$ git pull https://git.openjdk.org/jdk26u.git pull/115/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 115

View PR using the GUI difftool:
$ git pr show -t 115

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk26u/pull/115.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link
Copy Markdown

bridgekeeper bot commented Mar 18, 2026

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 18, 2026

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8379967: (process) Improve ProcessBuilder error reporting

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2240ff41795d1de76aab1ce69758fcbd827208de 8379967: (process) Improve ProcessBuilder error reporting Mar 18, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 18, 2026

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Mar 18, 2026
@tstuefe tstuefe marked this pull request as ready for review March 18, 2026 08:37
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 18, 2026

⚠️ @tstuefe This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 18, 2026
@mlbridge
Copy link
Copy Markdown

mlbridge bot commented Mar 18, 2026

Webrevs

@tstuefe
Copy link
Copy Markdown
Member Author

tstuefe commented Mar 19, 2026

/approval request This issue needs downporting as a prerequisite for downporting https://bugs.openjdk.org/browse/JDK-8377907. It is also very useful in itself. The patch carries only minimal risk. Tests: GHAs, manual tests ran (including the newly added ones) on Linux x64 (glibc and muslc).

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 19, 2026

@tstuefe usage: /approval [<id>] (request|cancel) [<text>]

@tstuefe
Copy link
Copy Markdown
Member Author

tstuefe commented Mar 19, 2026

/approval request This issue needs downporting as a prerequisite for downporting https://bugs.openjdk.org/browse/JDK-8377907. It is also very useful in itself. The patch carries only minimal risk. Tests: GHAs, manual tests ran (including the newly added ones) on Linux x64 (glibc and muslc).

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 19, 2026

@tstuefe
8379967: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Mar 19, 2026
@tstuefe
Copy link
Copy Markdown
Member Author

tstuefe commented Mar 24, 2026

/integrate

@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 24, 2026

Going to push as commit 79f7329.
Since your change was applied there have been 8 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 24, 2026
@openjdk openjdk bot closed this Mar 24, 2026
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 24, 2026
@openjdk
Copy link
Copy Markdown

openjdk bot commented Mar 24, 2026

@tstuefe Pushed as commit 79f7329.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant